Merged
Conversation
Contributor
|
cool! great job. so you find way to fix the workspace problem! Congratulations! |
- adds `--config` cli arg - relocates the plugin deno.json to source/deno.json - uses @duesabati/esbuild-deno-plugin instead of @luca - update workflow to use deno 2
Decodetalkers
approved these changes
Mar 27, 2025
Contributor
Decodetalkers
left a comment
Decodetalkers
left a comment
There was a problem hiding this comment.
Thank you very much!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses deno workspaces to manage example apps. This way, we can show the exact usage of the apps in this repo.
If you could take a look @Decodetalkers; although sorry it doesn't include your commits. I built off the main/origin just to keep my sanity. 😭
Changes
--configcli arg for specifyingdeno.jsonlocation@duesabati/esbuild-deno-plugininstead of@luca/esbuild_deno_loaderfor better workspace support. Currently have this andesbuildpinned to the patch, in order to be safer